Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): modify update method for config change in NLSLayer #732

Merged
merged 3 commits into from Oct 10, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Oct 10, 2023

Overview

This PR updates the updateConfig method in nlslayer pkg to support partial merged changes in the config instead of replacement while updating.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 328c795
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65252a609f6bcc0008c1c465
😎 Deploy Preview https://deploy-preview-732--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pyshx pyshx changed the title chore(Server): modify update method for config change in NLSLayer chore(server): modify update method for config change in NLSLayer Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #732 (fc3bc6c) into main (22a0e60) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head fc3bc6c differs from pull request most recent head 328c795. Consider uploading reports for the commit 328c795 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   26.77%   26.77%           
=======================================
  Files        1574     1574           
  Lines      172095   172095           
  Branches     3913     3913           
=======================================
  Hits        46079    46079           
  Misses     124927   124927           
  Partials     1089     1089           
Flag Coverage Δ
server 33.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pyshx pyshx merged commit 0853baf into main Oct 10, 2023
8 of 9 checks passed
@pyshx pyshx deleted the chore/update-nlslayer-update-in-server branch October 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant