Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): hide and show layer #735

Merged
merged 24 commits into from Oct 18, 2023
Merged

chore(web): hide and show layer #735

merged 24 commits into from Oct 18, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • implement hide/show layer UI
  • add hide/show functionalities

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5a6730a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/652fb6167144ad00080ef2a1
😎 Deploy Preview https://deploy-preview-735--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 10, 2023
@github-actions github-actions bot requested a review from pyshx October 10, 2023 16:03
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #735 (5a6730a) into main (6c8a42f) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   26.60%   26.58%   -0.02%     
==========================================
  Files        1587     1587              
  Lines      173676   173800     +124     
  Branches     3917     3917              
==========================================
+ Hits        46205    46207       +2     
- Misses     126382   126504     +122     
  Partials     1089     1089              
Flag Coverage Δ
web 24.90% <0.00%> (-0.03%) ⬇️
web-beta 24.90% <0.00%> (-0.03%) ⬇️
web-classic 24.90% <0.00%> (-0.03%) ⬇️
web-utils 24.90% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/Map/hooks.ts 16.40% <ø> (+0.12%) ⬆️
web/src/beta/features/Editor/Visualizer/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/core/engines/Cesium/Feature/index.tsx 32.27% <0.00%> (-0.30%) ⬇️
web/src/beta/components/ListItem/index.tsx 0.00% <0.00%> (ø)
.../beta/features/Editor/tabs/map/LeftPanel/index.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/LeftPanel/GroupField/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useLeftPanel.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useLayers.ts 0.00% <0.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@pyshx pyshx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaWaite @keiya01 Do we want the visibility to be handled on frontend level? We can also do it by making mutation to layer. Not sure if we want to retain visibility for layers when a session is finished 🤔

@mkumbobeaty mkumbobeaty merged commit 90e2b96 into main Oct 18, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/hide-show branch October 18, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants