Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix some bugs around feature selection functionality #736

Merged
merged 1 commit into from Oct 12, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Oct 11, 2023

Overview

Fix bugs around feature selection.

What I've done

  • Fix selection indicator to hide in correct step
  • Fix pickManyFromViewport
  • Fix property conversion for each feature.

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 1b85eb7
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65265fd74108f40008afb4ef
😎 Deploy Preview https://deploy-preview-736--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #736 (1b85eb7) into main (d4127b7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   26.72%   26.72%   -0.01%     
==========================================
  Files        1583     1583              
  Lines      172832   172835       +3     
  Branches     3913     3913              
==========================================
  Hits        46195    46195              
- Misses     125548   125551       +3     
  Partials     1089     1089              
Flag Coverage Δ
web 25.07% <0.00%> (-0.01%) ⬇️
web-beta 25.07% <0.00%> (-0.01%) ⬇️
web-classic 25.07% <0.00%> (-0.01%) ⬇️
web-utils 25.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/engines/Cesium/pickMany.ts 39.54% <0.00%> (ø)
web/src/beta/lib/core/engines/Cesium/utils.ts 15.06% <0.00%> (-0.04%) ⬇️
web/src/beta/lib/core/engines/Cesium/hooks.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@keiya01 keiya01 merged commit 2476c3b into main Oct 12, 2023
17 checks passed
@keiya01 keiya01 deleted the fix/selection-features branch October 12, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants