Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add date time field component #740

Merged
merged 9 commits into from Oct 18, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 16, 2023

Overview

Add Date and Time for beta reearth

What I've done

image
image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner October 16, 2023 13:14
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 54942fd
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/652f97d17b763f0008c48185
😎 Deploy Preview https://deploy-preview-740--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 16, 2023
@nina992 nina992 changed the title Chore: date time field component Chore(web): date time field component Oct 16, 2023
@nina992 nina992 changed the title Chore(web): date time field component chore(web): date time field component Oct 16, 2023
@nina992 nina992 changed the title chore(web): date time field component chore(web): add date time field component Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #740 (54942fd) into main (86dbb58) will decrease coverage by 0.02%.
The diff coverage is 2.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   26.61%   26.60%   -0.02%     
==========================================
  Files        1586     1587       +1     
  Lines      173598   173676      +78     
  Branches     3916     3917       +1     
==========================================
+ Hits        46204    46207       +3     
- Misses     126305   126380      +75     
  Partials     1089     1089              
Flag Coverage Δ
web 24.93% <2.46%> (-0.02%) ⬇️
web-beta 24.93% <2.46%> (-0.02%) ⬇️
web-classic 24.93% <2.46%> (-0.02%) ⬇️
web-utils 24.93% <2.46%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/services/api/propertyApi/utils.ts 43.09% <100.00%> (+0.19%) ⬆️
.../beta/components/fields/common/TextInput/index.tsx 0.00% <0.00%> (ø)
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
...src/beta/components/fields/DateTimeField/index.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@nina992 nina992 merged commit 6c8a42f into main Oct 18, 2023
16 checks passed
@nina992 nina992 deleted the chore-date-time-field-component branch October 18, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants