Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): timeline block #750

Merged
merged 63 commits into from Nov 8, 2023
Merged

chore(web): timeline block #750

merged 63 commits into from Nov 8, 2023

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Oct 19, 2023

Overview

What I've done

  • Implement timeline block UI
  • Add timeline Functionalities
  • Implement timeline block settings

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit e8a77ec
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654b37503105570008998da5
😎 Deploy Preview https://deploy-preview-750--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 19, 2023
@mkumbobeaty mkumbobeaty marked this pull request as ready for review October 23, 2023 06:46
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #750 (e8a77ec) into main (b97d67c) will decrease coverage by 0.14%.
The diff coverage is 1.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   25.95%   25.81%   -0.14%     
==========================================
  Files        1632     1636       +4     
  Lines      178263   179277    +1014     
  Branches     3916     3919       +3     
==========================================
+ Hits        46271    46287      +16     
- Misses     130903   131901     +998     
  Partials     1089     1089              
Flag Coverage Δ
web 24.05% <1.72%> (-0.16%) ⬇️
web-beta 24.05% <1.72%> (-0.16%) ⬇️
web-classic 24.05% <1.72%> (-0.16%) ⬇️
web-utils 24.05% <1.72%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/Icon/icons.ts 100.00% <100.00%> (ø)
web/src/beta/lib/core/Map/useTimelineManager.ts 43.45% <100.00%> (ø)
web/src/beta/lib/core/StoryPanel/constants.ts 100.00% <100.00%> (ø)
web/src/services/api/storytellingApi/blocks.ts 27.39% <ø> (+0.12%) ⬆️
web/src/services/gql/__gen__/graphql.ts 100.00% <100.00%> (ø)
.../beta/components/fields/common/TextInput/index.tsx 0.00% <0.00%> (ø)
...c/beta/features/Editor/Visualizer/convert-story.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/types.ts 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/Block/builtin/index.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Block/types.ts 0.00% <0.00%> (ø)
... and 9 more

... and 2 files with indirect coverage changes

@mkumbobeaty mkumbobeaty enabled auto-merge (squash) November 8, 2023 08:06
@mkumbobeaty mkumbobeaty merged commit f5ab499 into main Nov 8, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/timeline-block branch November 8, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants