Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix page title empty string #762

Merged
merged 8 commits into from Oct 30, 2023
Merged

chore: fix page title empty string #762

merged 8 commits into from Oct 30, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 24, 2023

Overview

Page title can become empty string and then can't be selected anymore (should go back to UNTITLED)

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner October 24, 2023 11:42
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit bb7c018
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/653f594298f66a0007e42235
😎 Deploy Preview https://deploy-preview-762--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #762 (bb7c018) into main (3df69f8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   26.25%   26.25%   -0.01%     
==========================================
  Files        1610     1610              
  Lines      176189   176193       +4     
  Branches     3898     3900       +2     
==========================================
  Hits        46253    46253              
- Misses     128847   128851       +4     
  Partials     1089     1089              
Flag Coverage Δ
web 24.54% <0.00%> (-0.01%) ⬇️
web-beta 24.54% <0.00%> (-0.01%) ⬇️
web-classic 24.54% <0.00%> (-0.01%) ⬇️
web-utils 24.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Editor/tabs/story/LeftPanel/ContentPage/index.tsx 0.00% <0.00%> (ø)
.../lib/core/StoryPanel/Block/builtin/Title/index.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@nina992 nina992 merged commit 44e573f into main Oct 30, 2023
15 of 16 checks passed
@nina992 nina992 deleted the chore--fix-story-title branch October 30, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants