Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server, web): add collection to property schemaGroup #764

Merged
merged 11 commits into from Oct 30, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Oct 25, 2023

Overview

This PR adds a collection to the property schemaGroup to support grouping of multiple group.
It also updates the web graphql files. generated when performing yarn gql

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 380f7dc
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/653f36d12c7d630008465e99

@pyshx pyshx changed the title chore(server): add collection to property schemaGroup chore(server, web): add collection to property schemaGroup Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #764 (380f7dc) into main (9d33b49) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   26.24%   26.26%   +0.01%     
==========================================
  Files        1610     1610              
  Lines      176098   176136      +38     
  Branches     3900     3900              
==========================================
+ Hits        46218    46255      +37     
- Misses     128791   128792       +1     
  Partials     1089     1089              
Flag Coverage Δ
server 33.42% <76.47%> (+0.02%) ⬆️
web 24.55% <92.30%> (+0.01%) ⬆️
web-beta 24.55% <92.30%> (+0.01%) ⬆️
web-classic 24.55% <92.30%> (+0.01%) ⬆️
web-utils 24.55% <92.30%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/pkg/plugin/manifest/convert.go 90.63% <100.00%> (+0.23%) ⬆️
server/pkg/plugin/manifest/schema_translation.go 81.76% <ø> (ø)
server/pkg/property/schema_group.go 83.58% <100.00%> (+1.32%) ⬆️
web/src/beta/lib/core/mantle/types/value.ts 100.00% <100.00%> (ø)
web/src/services/gql/__gen__/gql.ts 100.00% <100.00%> (ø)
web/src/services/gql/__gen__/graphql.ts 100.00% <ø> (ø)
.../internal/adapter/gql/gqlmodel/convert_property.go 1.19% <0.00%> (-0.01%) ⬇️
web/src/services/gql/fragments/property.ts 0.00% <0.00%> (ø)
server/pkg/property/schema_group_builder.go 89.58% <0.00%> (-5.98%) ⬇️

... and 2 files with indirect coverage changes

@pyshx pyshx marked this pull request as ready for review October 30, 2023 05:10
@pyshx pyshx merged commit 9cab761 into main Oct 30, 2023
17 of 18 checks passed
@pyshx pyshx deleted the chore/update-schema-for-collection-in-server branch October 30, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant