Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): add nlslayer in project & story publishing #769

Merged
merged 3 commits into from Oct 26, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Oct 26, 2023

Overview

This PR adds support for nlsLayers in published projects and story along with coreSupport as an indicative param for differentiation.

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit aadbed4
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6539f7144286cf0009e474b1

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #769 (aadbed4) into main (ade5cd7) will decrease coverage by 0.01%.
The diff coverage is 9.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
- Coverage   26.39%   26.38%   -0.01%     
==========================================
  Files        1604     1605       +1     
  Lines      175617   175690      +73     
  Branches     3930     3930              
==========================================
+ Hits        46354    46356       +2     
- Misses     128174   128245      +71     
  Partials     1089     1089              
Flag Coverage Δ
server 33.51% <9.67%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/pkg/scene/builder/scene.go 80.50% <100.00%> (+0.12%) ⬆️
...rnal/infrastructure/mongo/mongodoc/storytelling.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/nlslayer.go 0.00% <0.00%> (ø)
...rnal/adapter/gql/resolver_mutation_storytelling.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/project.go 13.69% <0.00%> (-0.27%) ⬇️
server/internal/usecase/interactor/storytelling.go 0.00% <0.00%> (ø)
server/pkg/scene/builder/builder.go 31.39% <26.92%> (-6.84%) ⬇️
server/pkg/scene/builder/nlsLayer.go 0.00% <0.00%> (ø)

@pyshx pyshx merged commit 4a3d089 into main Oct 26, 2023
16 of 17 checks passed
@pyshx pyshx deleted the chore/fix-beta-publishing-in-server branch October 26, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant