Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Add story background setting #775

Merged
merged 15 commits into from Nov 8, 2023
Merged

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Nov 1, 2023

Overview

In This pr we give the user the ability to modify the color of story background.

What I've done

  • Add color field to story setting
  • Modify the gql query
  • Make sure the story bgColor modified in/out editor mode
    image
    image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner November 1, 2023 05:14
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5f43539
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654b4f413eb81b000856c6b4
😎 Deploy Preview https://deploy-preview-775--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #775 (5f43539) into main (9c4c84a) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   25.81%   25.81%   -0.01%     
==========================================
  Files        1636     1636              
  Lines      179304   179327      +23     
  Branches     3920     3920              
==========================================
+ Hits        46289    46294       +5     
- Misses     131926   131944      +18     
  Partials     1089     1089              
Flag Coverage Δ
web 24.05% <12.50%> (-0.01%) ⬇️
web-beta 24.05% <12.50%> (-0.01%) ⬇️
web-classic 24.05% <12.50%> (-0.01%) ⬇️
web-utils 24.05% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <ø> (ø)
web/src/services/gql/__gen__/gql.ts 100.00% <100.00%> (ø)
web/src/services/gql/__gen__/graphql.ts 100.00% <ø> (ø)
web/src/beta/components/fields/ColorField/types.ts 0.00% <0.00%> (ø)
...c/beta/features/Editor/Visualizer/convert-story.ts 0.00% <0.00%> (ø)
...rojectSettings/innerPages/PublicSettings/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/PublishedVisualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/PublishedVisualizer/types.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/types.ts 0.00% <0.00%> (ø)
web/src/services/gql/fragments/story.ts 0.00% <0.00%> (ø)
... and 9 more

... and 3 files with indirect coverage changes

@nina992 nina992 changed the title chore(web):Add story background setting chore(web): Add story background setting Nov 6, 2023
@mkumbobeaty mkumbobeaty self-requested a review November 8, 2023 09:31
@nina992 nina992 merged commit f8ea057 into main Nov 8, 2023
16 checks passed
@nina992 nina992 deleted the chore/story-background-FE branch November 8, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants