Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): upgrade dependencies which don't include breaking changes #783

Merged
merged 3 commits into from Nov 2, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 2, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit eb32b0c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65433ab0780b1f00081021a6
😎 Deploy Preview https://deploy-preview-783--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #783 (eb32b0c) into main (2d69621) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   26.10%   26.10%   -0.01%     
==========================================
  Files        1621     1621              
  Lines      177189   177201      +12     
  Branches     3910     3904       -6     
==========================================
+ Hits        46255    46257       +2     
- Misses     129845   129855      +10     
  Partials     1089     1089              
Flag Coverage Δ
web 24.38% <0.00%> (-0.01%) ⬇️
web-beta 24.38% <0.00%> (-0.01%) ⬇️
web-classic 24.38% <0.00%> (-0.01%) ⬇️
web-utils 24.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...beta/lib/core/engines/Cesium/Feature/Raster/mvt.ts 16.18% <0.00%> (-0.36%) ⬇️
.../classic/core/engines/Cesium/Feature/Raster/mvt.ts 16.18% <0.00%> (-0.36%) ⬇️

... and 4 files with indirect coverage changes

@keiya01 keiya01 changed the title feat(web): upgrade deps for patch feat(web): upgrade dependencies which don't include breaking changes Nov 2, 2023
@keiya01 keiya01 marked this pull request as ready for review November 2, 2023 05:56
@keiya01 keiya01 requested a review from KaWaite as a code owner November 2, 2023 05:56
web/package.json Outdated
"@types/tinycolor2": "1.4.5",
"@types/uuid": "9.0.6",
"@vitejs/plugin-react": "4.1.0",
"@vitest/coverage-v8": "^0.34.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove ^ and vite again 🙏🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! eb32b0c

@keiya01 keiya01 merged commit 930fce4 into main Nov 2, 2023
15 of 16 checks passed
@keiya01 keiya01 deleted the chore/update-patch branch November 2, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants