Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): refactor property and revert core #788

Merged
merged 3 commits into from Nov 3, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 3, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 0f4305d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654480a7b0d5fc000846121c
😎 Deploy Preview https://deploy-preview-788--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #788 (0f4305d) into main (a85ca44) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   26.06%   26.04%   -0.02%     
==========================================
  Files        1625     1626       +1     
  Lines      177510   177626     +116     
  Branches     3909     3910       +1     
==========================================
+ Hits        46260    46262       +2     
- Misses     130161   130275     +114     
  Partials     1089     1089              
Flag Coverage Δ
web 24.31% <0.00%> (-0.02%) ⬇️
web-beta 24.31% <0.00%> (-0.02%) ⬇️
web-classic 24.31% <0.00%> (-0.02%) ⬇️
web-utils 24.31% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core/Crust/Widgets/Widget/builtin/Button/index.tsx 0.00% <0.00%> (ø)
...re/Crust/Widgets/Widget/builtin/Navigator/hooks.ts 0.00% <0.00%> (ø)
...ore/Crust/Widgets/Widget/builtin/Timeline/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/convert.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
...Crust/Widgets/Widget/builtin/Button/MenuButton.tsx 0.00% <0.00%> (ø)
...c/beta/features/Editor/Visualizer/convert-story.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@KaWaite KaWaite marked this pull request as ready for review November 3, 2023 05:26
@KaWaite KaWaite requested a review from keiya01 as a code owner November 3, 2023 05:26
@KaWaite KaWaite merged commit e844ddd into main Nov 3, 2023
17 checks passed
@KaWaite KaWaite deleted the refactor-property-conversion branch November 3, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant