Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): auto create page on project creation #794

Merged
merged 3 commits into from Nov 8, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 7, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 7401e39
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654ae34c88cbc7000872cc8c
😎 Deploy Preview https://deploy-preview-794--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #794 (7401e39) into main (0c16b45) will decrease coverage by 0.01%.
The diff coverage is 18.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   25.97%   25.96%   -0.01%     
==========================================
  Files        1630     1630              
  Lines      178138   178179      +41     
  Branches     3913     3914       +1     
==========================================
+ Hits        46263    46273      +10     
- Misses     130786   130817      +31     
  Partials     1089     1089              
Flag Coverage Δ
web 24.23% <18.64%> (-0.01%) ⬇️
web-beta 24.23% <18.64%> (-0.01%) ⬇️
web-classic 24.23% <18.64%> (-0.01%) ⬇️
web-utils 24.23% <18.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/services/gql/__gen__/gql.ts 100.00% <100.00%> (ø)
web/src/services/gql/__gen__/graphql.ts 100.00% <100.00%> (ø)
web/src/services/gql/queries/scene.ts 100.00% <100.00%> (ø)
...c/beta/features/Editor/DataSourceManager/utils.tsx 0.00% <0.00%> (ø)
...features/Editor/DataSourceManager/Common/index.tsx 0.00% <0.00%> (ø)
web/src/services/api/projectApi.ts 13.40% <10.52%> (-0.11%) ⬇️
...rc/classic/components/organisms/Dashboard/hooks.ts 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@KaWaite KaWaite merged commit 6d53607 into main Nov 8, 2023
15 of 16 checks passed
@KaWaite KaWaite deleted the create-page-on-project-creation branch November 8, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant