Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): new beta notification #796

Merged
merged 2 commits into from Nov 8, 2023
Merged

chore(web): new beta notification #796

merged 2 commits into from Nov 8, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 8, 2023

Overview

  • Moves notification's to the middle of the screen, away from user actions. It is kept a bit higher so that it doesn't get in the way of the visualizer. But also not so high it becomes part of the navbar
  • Cleans up the UI. Shows the cancel button only on hover. Rounded corners.
  • Updates UX. Shows notifications for shorter time, but if you hover over the notification it'll persist until you stop hovering

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5987f74
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654af684a2bc5c000803551d
😎 Deploy Preview https://deploy-preview-796--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 8, 2023
@KaWaite KaWaite self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #796 (a1ea294) into main (6d53607) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   25.96%   25.96%   -0.01%     
==========================================
  Files        1630     1630              
  Lines      178185   178200      +15     
  Branches     3914     3913       -1     
==========================================
+ Hits        46271    46274       +3     
- Misses     130825   130837      +12     
  Partials     1089     1089              
Flag Coverage Δ
web 24.22% <0.00%> (-0.01%) ⬇️
web-beta 24.22% <0.00%> (-0.01%) ⬇️
web-classic 24.22% <0.00%> (-0.01%) ⬇️
web-utils 24.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Notification/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Notification/index.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@KaWaite KaWaite merged commit 607773e into main Nov 8, 2023
5 of 6 checks passed
@KaWaite KaWaite deleted the beta-notifications branch November 8, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant