Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix text and camera button blocks #797

Merged
merged 3 commits into from Nov 8, 2023
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 8, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@github-actions github-actions bot requested a review from pyshx November 8, 2023 06:00
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit c304a7c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654b23e7ab890a00085f5cd3
😎 Deploy Preview https://deploy-preview-797--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #797 (c304a7c) into main (607773e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   25.96%   25.95%   -0.01%     
==========================================
  Files        1630     1632       +2     
  Lines      178215   178263      +48     
  Branches     3913     3916       +3     
==========================================
+ Hits        46272    46273       +1     
- Misses     130854   130901      +47     
  Partials     1089     1089              
Flag Coverage Δ
web 24.21% <0.00%> (-0.01%) ⬇️
web-beta 24.21% <0.00%> (-0.01%) ⬇️
web-classic 24.21% <0.00%> (-0.01%) ⬇️
web-utils 24.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Notification/hooks.ts 0.00% <0.00%> (ø)
...src/beta/lib/core/StoryPanel/ActionPanel/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/lexical/RichTextEditor/index.tsx 0.00% <0.00%> (ø)
...lib/core/StoryPanel/Block/builtin/Camera/index.tsx 0.00% <0.00%> (ø)
...a/lib/core/StoryPanel/Block/builtin/Text/index.tsx 0.00% <0.00%> (ø)
.../lib/core/StoryPanel/Block/builtin/Text/Editor.tsx 0.00% <0.00%> (ø)
...b/core/StoryPanel/Block/builtin/Camera/Content.tsx 0.00% <0.00%> (ø)
...e/StoryPanel/Block/builtin/Camera/Editor/index.tsx 0.00% <0.00%> (ø)
...re/StoryPanel/Block/builtin/Camera/Editor/hooks.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@KaWaite KaWaite merged commit b97d67c into main Nov 8, 2023
17 checks passed
@KaWaite KaWaite deleted the misc-improvements branch November 8, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant