Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix classic notification bar #804

Merged
merged 1 commit into from Nov 9, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 9, 2023

Overview

Changes made a week ago spliting global jotai state made it so there were conflicts that broke at least the Notification Bar in classic. This merges the jotai state declarations again and makes sure there is no duplicate

As a side-effect, now classic uses the updated Notification Banner (centered, prettyified, etc)

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 3140794
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654c6ac0a912400008fe47be
😎 Deploy Preview https://deploy-preview-804--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #804 (3140794) into main (0b02908) will increase coverage by 0.02%.
The diff coverage is 40.74%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   25.75%   25.78%   +0.02%     
==========================================
  Files        1636     1632       -4     
  Lines      179729   179424     -305     
  Branches     3920     3908      -12     
==========================================
- Hits        46295    46257      -38     
+ Misses     132345   132078     -267     
  Partials     1089     1089              
Flag Coverage Δ
web 24.01% <40.74%> (+0.02%) ⬆️
web-beta 24.01% <40.74%> (+0.02%) ⬆️
web-classic 24.01% <40.74%> (+0.02%) ⬆️
web-utils 24.01% <40.74%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ponents/organisms/Authentication/RootPage/hooks.ts 0.00% <0.00%> (ø)
...omponents/organisms/Common/AssetContainer/hooks.ts 0.00% <0.00%> (ø)
...nts/organisms/EarthEditor/DatasetInfoPane/hooks.ts 0.00% <0.00%> (ø)
...mponents/organisms/EarthEditor/ExportPane/hooks.ts 0.00% <0.00%> (ø)
...c/components/organisms/EarthEditor/Header/hooks.ts 0.00% <0.00%> (ø)
...components/organisms/EarthEditor/LeftMenu/hooks.ts 0.00% <0.00%> (ø)
...nts/organisms/EarthEditor/PrimitiveHeader/hooks.ts 0.00% <0.00%> (ø)
...rganisms/EarthEditor/PropertyPane/hooks-queries.ts 0.00% <0.00%> (ø)
...omponents/organisms/EarthEditor/RightMenu/hooks.ts 0.00% <0.00%> (ø)
...nents/organisms/EarthEditor/TagPane/commonHooks.ts 0.00% <0.00%> (ø)
... and 22 more

... and 3 files with indirect coverage changes

@KaWaite KaWaite merged commit 1ca1531 into main Nov 9, 2023
17 of 18 checks passed
@KaWaite KaWaite deleted the fix-classic-notification-bar branch November 9, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant