Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Story page click away #806

Merged
merged 5 commits into from Nov 14, 2023
Merged

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Remove story page clickaway

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 4464733
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65537a841d0f290009d8ca8c
😎 Deploy Preview https://deploy-preview-806--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 13, 2023
@github-actions github-actions bot requested a review from pyshx November 13, 2023 06:42
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #806 (d58d587) into main (80b65fa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d58d587 differs from pull request most recent head 4464733. Consider uploading reports for the commit 4464733 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   25.72%   25.72%   -0.01%     
==========================================
  Files        1635     1635              
  Lines      179874   179891      +17     
  Branches     3910     3912       +2     
==========================================
  Hits        46268    46268              
- Misses     132517   132534      +17     
  Partials     1089     1089              
Flag Coverage Δ
web 23.94% <0.00%> (-0.01%) ⬇️
web-beta 23.94% <0.00%> (-0.01%) ⬇️
web-classic 23.94% <0.00%> (-0.01%) ⬇️
web-utils 23.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <ø> (ø)
...c/beta/lib/core/StoryPanel/SelectableArea/hooks.ts 0.00% <0.00%> (ø)
.../beta/lib/core/StoryPanel/SelectableArea/index.tsx 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit b97cd2e into main Nov 14, 2023
12 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/click-away-storypage branch November 14, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants