Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix feature unselection #812

Merged
merged 3 commits into from Nov 15, 2023
Merged

chore(web): fix feature unselection #812

merged 3 commits into from Nov 15, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 14, 2023

Overview

The selected feature color wasn't updated to default color when I select nothing(click base-map). So I fixed this issue.

What I've done

What I haven't done

How I tested

  1. Click some 3dtile's feature in VIEW3.0 plugin
  2. Then the color of model should be changed.
  3. Click base-map
  4. Then the color of model should be default color.

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Nov 14, 2023
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 1ec6643
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6554628cbb4fd200088d24a0
😎 Deploy Preview https://deploy-preview-812--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keiya01 keiya01 changed the title fix(web): feature unselection chore(web): fix feature unselection Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #812 (dafc773) into main (80b65fa) will decrease coverage by 0.01%.
The diff coverage is 5.88%.

❗ Current head dafc773 differs from pull request most recent head 0c9a537. Consider uploading reports for the commit 0c9a537 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   25.72%   25.72%   -0.01%     
==========================================
  Files        1635     1635              
  Lines      179874   179886      +12     
  Branches     3910     3911       +1     
==========================================
+ Hits        46268    46269       +1     
- Misses     132517   132528      +11     
  Partials     1089     1089              
Flag Coverage Δ
web 23.94% <5.88%> (-0.01%) ⬇️
web-beta 23.94% <5.88%> (-0.01%) ⬇️
web-classic 23.94% <5.88%> (-0.01%) ⬇️
web-utils 23.94% <5.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/Map/Layers/hooks.ts 83.14% <5.88%> (-1.14%) ⬇️

... and 1 file with indirect coverage changes

@keiya01 keiya01 merged commit 3e6b7c6 into main Nov 15, 2023
5 of 6 checks passed
@keiya01 keiya01 deleted the fix/feature-unselect branch November 15, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants