Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): double click on page name #815

Merged
merged 6 commits into from Nov 16, 2023
Merged

chore(web): double click on page name #815

merged 6 commits into from Nov 16, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • double click to edit page name

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 54ef726
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6555c7033d777400080a8fb0
😎 Deploy Preview https://deploy-preview-815--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot requested a review from pyshx November 14, 2023 18:23
@github-actions github-actions bot added the web label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #815 (54ef726) into main (f4fc804) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   25.72%   25.70%   -0.03%     
==========================================
  Files        1635     1636       +1     
  Lines      179907   180081     +174     
  Branches     3911     3912       +1     
==========================================
  Hits        46288    46288              
- Misses     132530   132704     +174     
  Partials     1089     1089              
Flag Coverage Δ
web 23.92% <0.00%> (-0.03%) ⬇️
web-beta 23.92% <0.00%> (-0.03%) ⬇️
web-classic 23.92% <0.00%> (-0.03%) ⬇️
web-utils 23.92% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
.../core/StoryPanel/Block/builtin/Timeline/Editor.tsx 0.00% <0.00%> (ø)
...eta/features/Editor/tabs/story/LeftPanel/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useLeftPanel.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/hooks.ts 0.00% <0.00%> (ø)
.../Editor/tabs/story/LeftPanel/ContentPage/index.tsx 0.00% <0.00%> (ø)
...itor/tabs/story/LeftPanel/ContentPage/PageItem.tsx 0.00% <0.00%> (ø)

Copy link
Contributor

@pyshx pyshx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkumbobeaty mkumbobeaty merged commit ccf3c25 into main Nov 16, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/double-click branch November 16, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants