Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): remember the editor settings #825

Merged
merged 18 commits into from Dec 18, 2023
Merged

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • remember width resize

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit faa710c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/657fdc2f0fffa40008e9b367
😎 Deploy Preview https://deploy-preview-825--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 20, 2023
@mkumbobeaty mkumbobeaty changed the title chore(web); remember the editor settings in local storage chore(web): remember the editor settings Nov 20, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #825 (faa710c) into main (fb496e3) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 29.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
+ Coverage   25.84%   25.85%   +0.01%     
==========================================
  Files        1642     1645       +3     
  Lines      181117   181457     +340     
  Branches     3885     3889       +4     
==========================================
+ Hits        46801    46907     +106     
- Misses     133227   133461     +234     
  Partials     1089     1089              
Flag Coverage Δ
web 24.12% <29.11%> (+0.01%) ⬆️
web-beta 24.12% <29.11%> (+0.01%) ⬆️
web-classic 24.12% <29.11%> (+0.01%) ⬆️
web-utils 24.12% <29.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/Map/Layers/hooks.ts 83.20% <100.00%> (+0.01%) ⬆️
...src/beta/lib/core/engines/Cesium/Feature/index.tsx 34.18% <100.00%> (+0.56%) ⬆️
web/src/beta/lib/core/mantle/types/appearance.ts 100.00% <100.00%> (ø)
web/src/beta/features/Editor/Settings/index.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/LeftPanel/GroupField/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/Map/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/engines/Cesium/utils.ts 15.56% <20.00%> (+0.21%) ⬆️
web/src/beta/components/Resizable/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/core/engines/Cesium/Feature/utils.tsx 67.30% <58.33%> (-0.44%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

@mkumbobeaty mkumbobeaty enabled auto-merge (squash) December 18, 2023 05:54
@mkumbobeaty mkumbobeaty merged commit 02aac2b into main Dec 18, 2023
15 of 16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/editor-localstorage branch December 18, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants