Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): timefield bug fix #828

Merged
merged 11 commits into from Nov 23, 2023
Merged

chore(web): timefield bug fix #828

merged 11 commits into from Nov 23, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Time-Field UI long text issue

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit f592625
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/655f0075ca55f60008d61d01
😎 Deploy Preview https://deploy-preview-828--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 21, 2023
@mkumbobeaty mkumbobeaty changed the title chore(web: timefield bug fix chore(web): timefield bug fix Nov 22, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #828 (f592625) into main (09338f5) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   25.69%   25.69%           
=======================================
  Files        1637     1637           
  Lines      180169   180164    -5     
  Branches     3913     3913           
=======================================
+ Hits        46286    46290    +4     
+ Misses     132794   132785    -9     
  Partials     1089     1089           
Flag Coverage Δ
web 23.91% <0.00%> (+<0.01%) ⬆️
web-beta 23.91% <0.00%> (+<0.01%) ⬆️
web-classic 23.91% <0.00%> (+<0.01%) ⬆️
web-utils 23.91% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/beta/components/fields/DateTimeField/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit df99b18 into main Nov 23, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/time-field-fix branch November 23, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants