Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Fix story block creation and preview #837

Merged
merged 11 commits into from Nov 28, 2023
Merged

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • fix bug for creating new block

Screenshot from 2023-11-27 12-28-57

Screencast.from.27-11-2023.12.25.31.ALASIRI.webm
  • fix double click to enter edit mode in Preview

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit c39a8a1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6565851608509b00080049fe
😎 Deploy Preview https://deploy-preview-837--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #837 (c39a8a1) into main (ed2931e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   25.67%   25.67%   -0.01%     
==========================================
  Files        1638     1638              
  Lines      180326   180326              
  Branches     3914     3914              
==========================================
- Hits        46292    46290       -2     
- Misses     132945   132947       +2     
  Partials     1089     1089              
Flag Coverage Δ
web 23.89% <0.00%> (-0.01%) ⬇️
web-beta 23.89% <0.00%> (-0.01%) ⬇️
web-classic 23.89% <0.00%> (-0.01%) ⬇️
web-utils 23.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
.../lib/core/StoryPanel/Block/builtin/common/hooks.ts 0.00% <0.00%> (ø)
...lib/core/StoryPanel/Block/builtin/Timeline/hook.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit ebf99c0 into main Nov 28, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/bug-fix branch November 28, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants