Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix timeline block breaking when time set to current day #847

Merged
merged 12 commits into from Dec 1, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Fix playing timeline block

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 1ce1a8c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6568c8b75ab7a000088c878c
😎 Deploy Preview https://deploy-preview-847--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #847 (1ce1a8c) into main (1b1e83d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   25.63%   25.63%   -0.01%     
==========================================
  Files        1643     1643              
  Lines      180628   180630       +2     
  Branches     3919     3917       -2     
==========================================
- Hits        46298    46296       -2     
- Misses     133241   133245       +4     
  Partials     1089     1089              
Flag Coverage Δ
web 23.84% <0.00%> (-0.01%) ⬇️
web-beta 23.84% <0.00%> (-0.01%) ⬇️
web-classic 23.84% <0.00%> (-0.01%) ⬇️
web-utils 23.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lib/core/StoryPanel/Block/builtin/Timeline/hook.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@KaWaite KaWaite changed the title chore(web): Timeline block bug fix chore(web): fix timeline block breaking when time set to current day Dec 1, 2023
@KaWaite KaWaite merged commit a69d813 into main Dec 1, 2023
16 of 18 checks passed
@KaWaite KaWaite deleted the chore/timeline-fix branch December 1, 2023 04:46
@mkumbobeaty mkumbobeaty restored the chore/timeline-fix branch December 5, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants