New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): fix timeline block breaking when time set to current day #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nina992 <nouralali992@gmail.com> Co-authored-by: pyshx <piyushchauhan1004@gmail.com>
This reverts commit 912d681.
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 25.63% 25.63% -0.01%
==========================================
Files 1643 1643
Lines 180628 180630 +2
Branches 3919 3917 -2
==========================================
- Hits 46298 46296 -2
- Misses 133241 133245 +4
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KaWaite
approved these changes
Dec 1, 2023
KaWaite
changed the title
chore(web): Timeline block bug fix
chore(web): fix timeline block breaking when time set to current day
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo