Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): refactoring web code #858

Merged
merged 20 commits into from Dec 15, 2023
Merged

chore(web): refactoring web code #858

merged 20 commits into from Dec 15, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Dec 13, 2023

Overview

  • Upped node version 16-> 18 due to vite 5 using rollup 4, which wants 18
  • upgraded vite from 4->5
  • moved from vitejs/plugin-react to vitejs/plugin-react-swc. This makes build very fast and only affects projects using certain babel plugins, which we don’t.
  • Updated Icon component significantly and how we use svgs (svgr).
  • Updated which components we are lazy loading in routing/index.tsx

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@KaWaite KaWaite self-assigned this Dec 13, 2023
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 008166a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/657beb3b8a39ea000972b1c4
😎 Deploy Preview https://deploy-preview-858--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Dec 13, 2023
@KaWaite KaWaite changed the title chore(web): refactoring chore(web): refactoring web code Dec 14, 2023
@KaWaite KaWaite marked this pull request as ready for review December 14, 2023 04:40
@github-actions github-actions bot requested a review from pyshx December 14, 2023 04:40
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #858 (008166a) into main (1d35d9d) will increase coverage by 0.26%.
The diff coverage is 62.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   25.56%   25.83%   +0.26%     
==========================================
  Files        1644     1642       -2     
  Lines      181111   181071      -40     
  Branches     3920     3885      -35     
==========================================
+ Hits        46309    46780     +471     
+ Misses     133713   133202     -511     
  Partials     1089     1089              
Flag Coverage Δ
web 24.10% <62.01%> (+0.32%) ⬆️
web-beta 24.10% <62.01%> (+0.32%) ⬆️
web-classic 24.10% <62.01%> (+0.32%) ⬆️
web-utils 24.10% <62.01%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/Icon/icons.ts 100.00% <100.00%> (ø)
web/src/beta/components/Icon/index.tsx 98.71% <100.00%> (+12.86%) ⬆️
...rust/Widgets/Widget/builtin/Navigator/UI/index.tsx 100.00% <100.00%> (ø)
...Crust/Widgets/Widget/builtin/Timeline/UI/index.tsx 100.00% <100.00%> (ø)
web/src/beta/lib/core/Crust/utils.ts 91.66% <100.00%> (ø)
web/src/classic/core/Crust/utils.ts 91.66% <100.00%> (ø)
web/src/beta/components/Button/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/TabMenu/index.tsx 0.00% <0.00%> (ø)
...rc/beta/lib/core/engines/Cesium/core/Indicator.tsx 0.00% <0.00%> (ø)
web/src/classic/util/value.ts 71.23% <0.00%> (ø)
... and 4 more

... and 99 files with indirect coverage changes

@KaWaite KaWaite merged commit 7f0e761 into main Dec 15, 2023
17 checks passed
@KaWaite KaWaite deleted the cleanup-fe-repo-2023 branch December 15, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant