Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: model onReady method fires at wrong moment #622

Merged
merged 4 commits into from
Oct 3, 2023
Merged

fix: model onReady method fires at wrong moment #622

merged 4 commits into from
Oct 3, 2023

Conversation

bigkrp
Copy link
Contributor

@bigkrp bigkrp commented Aug 8, 2023

resolving this issue

@rot1024 rot1024 changed the title Model onReady method fires at wrong moment fix: model onReady method fires at wrong moment Aug 29, 2023
keiya01
keiya01 reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@keiya01 keiya01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Please check this comment:pray:

src/Model/Model.ts Outdated Show resolved Hide resolved
@keiya01 keiya01 requested a review from airslice August 30, 2023 00:46
@bigkrp
Copy link
Contributor Author

bigkrp commented Sep 4, 2023

@keiya01 used state for the listener, please review changes

@bigkrp
Copy link
Contributor Author

bigkrp commented Sep 18, 2023

Please review

@keiya01 keiya01 merged commit c210e05 into reearth:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiya01 keiya01 keiya01 left review comments

@airslice airslice Awaiting requested review from airslice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bigkrp @keiya01