-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "v" prefix in incremented version #8
Comments
Yup, can look at that .. I think I'd make it an optional flag, rather than automatic e.g. with:
scheme: semver
increment: patch
v_prefix: true # defaults to false I hope that would suit |
An optional flag would definitely work! I was hoping we could find a way to detect if it was in the previous tag and automatically add it back though? It seems like someone starting with tag I don't meant to sound harsh, but this Action "enforces" its opinion of what version numbers should look like, rather than incrementing existing numbers/schemes. |
You are right - it's opinionated. It deliberately strips I do understand that Golang projects require the What about an additional output |
I appreciate that detailed response @ps-jay, your reasoning makes perfect sense. And I'm right there with you on making tools that at least try to push folks in the right direction towards consistency 馃槈 Your suggestion of outputting an additional |
Hello @ps-jay. Just following up to note that I've talked with my team about this " Feel free to close this issue, and thanks again! |
Hey there 馃憢 this looks like a great Action!
I see in the lookup, any
v
prefix in the latest tag is stripped:This makes the increment math way easier!
I wonder if it would be possible to support adding the
v
prefix back, after the new version is created, if it was there in the first place?The text was updated successfully, but these errors were encountered: