Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO Usage rollover , alert and disable on alert inconsistency #1104

Closed
ranjib opened this issue Apr 5, 2020 · 3 comments
Closed

ATO Usage rollover , alert and disable on alert inconsistency #1104

ranjib opened this issue Apr 5, 2020 · 3 comments
Assignees
Labels
Projects

Comments

@ranjib
Copy link
Collaborator

ranjib commented Apr 5, 2020

  • Hourly usage of ato data in reef-pi metric system resets usage: Establish correct behavior. If reset is required, make it more explicit (tooltip for "alert on disable")
  • Alerts when configure for usage, along with "alert limit" rolls over and does not reset hourly. Unsent alerts are flushed in the beginning of new hour: Investigate, reproduce and make behavior consistent with to usage metric
@ranjib ranjib added the bug label Apr 5, 2020
@ranjib ranjib added this to Backlog in 4.0 Apr 5, 2020
@ranjib ranjib moved this from Backlog to In-Progress in 4.0 Apr 24, 2020
@Simonv92
Copy link

Simonv92 commented May 1, 2020

Don't know if you've already figure it out, on 3.3.1 the ATO "disable on alert" doesn't works fine. If I set a value below 100s ATO turn OFF immediately after a sensor trigger, if I set a value of 120 or greater the ATO will never be disabled.

@ranjib
Copy link
Collaborator Author

ranjib commented May 4, 2020

I have pushed a fix recently that I think will resolve this issue #1121

@ranjib ranjib moved this from In-Progress to Done in 4.0 May 12, 2020
@ranjib
Copy link
Collaborator Author

ranjib commented May 19, 2020

Fix available in current release

@ranjib ranjib closed this as completed May 19, 2020
@ranjib ranjib self-assigned this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
4.0
Done
Development

No branches or pull requests

2 participants