Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta API for PWM profiles #659

Closed
ranjib opened this issue Dec 1, 2018 · 5 comments
Closed

Add meta API for PWM profiles #659

ranjib opened this issue Dec 1, 2018 · 5 comments
Projects
Milestone

Comments

@ranjib
Copy link
Collaborator

ranjib commented Dec 1, 2018

Wavemaker and LED lighting both works by varying PWM values over time. Currently reef-pi only supports LED lights and this variation can be either user-defined at two hours interval (auto-profile) or diurnal cycle. This does not let users customize the time interval or succinctly represent the repeats in a profile. Making arbitrary light control profile or wavemaker profile hard.

The scope of this issue is to provide a way to let users define an arbitrary profile that represents PWM variation with time and then associated these profiles with individual lights or powerheads. Once implemented profiles will allow implementing popular wave maker modes as well re-implementing the existing auto, fixed and diurnal using it.

  • Auto
  • Diurnal
  • Fixed
  • Wavemaker profiles (??)
  • Lunar cycle
@gfalvo
Copy link

gfalvo commented Dec 28, 2018

This would be an awesome upgrade! I am using two Jeabo PP-4 wavemakers and a Simplicity skimmer, all run from 0-5 PWM control from my reef-pi. The skimmer is easy as I run it at 99%, and turn it down to 50% for feeding time, but I would love to make profiles for my two wave-makers.

@ranjib ranjib added this to TODO in 3.0 Jan 4, 2019
@ranjib ranjib added this to the 3.0 milestone Jan 18, 2019
@ranjib
Copy link
Collaborator Author

ranjib commented Jan 18, 2019

#688

@ranjib
Copy link
Collaborator Author

ranjib commented Jun 2, 2019

required for: #381

@ranjib
Copy link
Collaborator Author

ranjib commented Jun 2, 2019

required for: #631

@ranjib ranjib moved this from TODO to In progress in 3.0 Aug 7, 2019
@ranjib ranjib moved this from In progress to Done in 3.0 Aug 18, 2019
@ranjib
Copy link
Collaborator Author

ranjib commented Sep 28, 2019

We have exapanded on the pwm profile offerings with custom profiles and more. After using them, I felt a dedicated pwm profile api is not super useful, and co-locating the profiles as first class attributes with their consumers (light channel or wavemaker pumps) is more intuitive.

@ranjib ranjib closed this as completed Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
3.0
  
Done
Development

No branches or pull requests

2 participants