Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left Hand Y-Axis on Temperature Sensor shows wrong scale v3.0 #993

Closed
adityaduggal opened this issue Dec 14, 2019 · 2 comments
Closed

Left Hand Y-Axis on Temperature Sensor shows wrong scale v3.0 #993

adityaduggal opened this issue Dec 14, 2019 · 2 comments
Labels

Comments

@adityaduggal
Copy link

Describe the bug
The bug is in the graph for heater control where the left hand axis of the heater control for temperature is taking the values from deg F and not from deg C as shown in the screenshot.

To Reproduce
Steps to reproduce the behaviour:

  1. Select the temperature sensor graph scale to Celsius.
  2. Now the left hand graph for temperature is correctly shown and in the screenshot but the right hand graph which shows the time for heater ON is skewed since its taking the values from deg F scale as well for the maximum values.

Expected behaviour
The left hand side is taking the values from deg F scale instead it should be showing the deg C scale which would make the temperature line more visible even for the heater graph

Screenshots
image

Desktop (please complete the following information):

  • Device [Pi0-wifi]
  • reef-pi version [3.0]
  • Browser [safari]
@ranjib
Copy link
Collaborator

ranjib commented Jan 6, 2020

@adityaduggal did you created the temperature controller with celsius as unit? I just tried and it worked for me. If you switch unit once a sensor is created then it will have this effect, we can back comput and fix it, but it will be lot more work and not sure if we can maintain all other related things coherently (like chart etc) as we dont have all the historical data. We can make sure that the unit is immutable after creation (i.e. users wont be able to change it once created) , i deliberately chose not to. but we can revisit this. I am closing this i dont am not taking any action item from this. Feel free to reopen this ticket if you have other thoughts,

@ranjib ranjib closed this as completed Jan 6, 2020
@adityaduggal
Copy link
Author

Hi @ranjib
I have created a new temperature sensor with Celcius selected and again I am getting the issue of the left hand axis range on temperature historical graph is skewed goes upto 86 deg Celcius ideally it should have gone upto 25 deg celcius as in the Temperature current graph. I know you have closed this issue but I think this issue is persisting.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants