Add some macros from html5ever #5
Conversation
These are adapted [1] from html5ever, which is licensed MIT/ASL2.
I wasn't sure if you planned for people to use this library as
#[macro_use]
extern crate mac;
i.e. with no list of specific macros to import. For that reason I gave these
macros an "ext_" prefix, as they are unlikely to be useful outside of writing
syntax extensions.
[1]: https://github.com/servo/html5ever/blob/master/macros/src/internal.rs
|
I relicensed the crate under MIT/Apache-2.0 under a suggestion from reddit. Reviewing this now. |
| /// # } | ||
| /// ``` | ||
| #[macro_export] | ||
| macro_rules! format_if { |
There was a problem hiding this comment.
I look at this macro and I see a verbosity switch. The really cool thing here is being able to switch being verbose (full, formatted, allocated error) and quick (short, borrowed error).
In light of this, it might be neat to re-use the verbosity levels and setup from the log crate and branch on that. If the logging setup isn't ideal, we can also just use the verbosity levels and leave them unconnected. Thoughts?
There was a problem hiding this comment.
That's an interesting idea. The log crate levels don't really match the html5ever use case, though. You don't need this if you're printing thru the log crate, only when reporting errors up to a library client.
We can merge the simple version now and think about this more.
|
Left some thoughts on |
|
Actually, I'm curious why the syntax-extension-related macros need to be macros at all, they look like they could be functions. |
|
|
|
Oh, my mistake, I missed the |
| #[macro_export] | ||
| macro_rules! ext_bail_if { | ||
| ($e:expr, $cx:expr, $sp:expr, $msg:expr) => {{ | ||
| if $e { bail!($cx, $sp, $msg) } |
|
Can you add tests for these macros, which can be as simple as just calling them once? Right now there's almost no checking for if any of these macros will actually compile when expanded (see typo of |
|
The doctests are live, but the syntax ext macros don't have any. |
|
Doctests are good then - I won't make you make doctests for the syntax ext macros because that sounds painful. |
|
I plan to start using these in h5e as soon as the PR is merged, so we'll find out if they break :) |
|
Woo! |
These are licensed MIT/ASL2.