Remove Add/Sub/Mul/Div/Rem impls for &OrderedFloat

These caused type infernence errors due to a bug in rustc. Fixes #105.
reem · Apr 30, 2022 · a849e73 · a849e73
1 parent 61975f1
commit a849e73
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 26 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -253,18 +253,6 @@ macro_rules! impl_ordered_float_binop {
             }
         }
 
-        impl<'a, T> $imp for &'a OrderedFloat<T>
-        where
-            &'a T: $imp,
-        {
-            type Output = OrderedFloat<<&'a T as $imp>::Output>;
-
-            #[inline]
-            fn $method(self, other: Self) -> Self::Output {
-                OrderedFloat((self.0).$method(&other.0))
-            }
-        }
-
         impl<'a, T> $imp<OrderedFloat<T>> for &'a OrderedFloat<T>
         where
             &'a T: $imp<T>,
@@ -301,19 +289,6 @@ macro_rules! impl_ordered_float_binop {
             }
         }
 
-        #[doc(hidden)] // Added accidentally; remove in next major version
-        impl<'a, T> $imp<&'a Self> for &'a OrderedFloat<T>
-        where
-            &'a T: $imp,
-        {
-            type Output = OrderedFloat<<&'a T as $imp>::Output>;
-
-            #[inline]
-            fn $method(self, other: &'a Self) -> Self::Output {
-                OrderedFloat((self.0).$method(&other.0))
-            }
-        }
-
         impl<T: $assign_imp> $assign_imp<T> for OrderedFloat<T> {
             #[inline]
             fn $assign_method(&mut self, other: T) {

diff --git a/tests/test.rs b/tests/test.rs
@@ -599,7 +599,6 @@ fn add() {
     assert_eq!(OrderedFloat(0.0) + OrderedFloat(0.0), 0.0);
     assert_eq!(OrderedFloat(0.0) + &OrderedFloat(0.0), 0.0);
     assert_eq!(&OrderedFloat(0.0) + OrderedFloat(0.0), 0.0);
-    assert_eq!(&OrderedFloat(0.0) + &OrderedFloat(0.0), 0.0);
     assert_eq!(OrderedFloat(0.0) + 0.0, 0.0);
     assert_eq!(OrderedFloat(0.0) + &0.0, 0.0);
     assert_eq!(&OrderedFloat(0.0) + 0.0, 0.0);