Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with nightly as of 2018-02-28 #90

Open
svenstaro opened this issue Feb 28, 2018 · 12 comments
Open

Broken with nightly as of 2018-02-28 #90

svenstaro opened this issue Feb 28, 2018 · 12 comments

Comments

@svenstaro
Copy link
Contributor

I currently get this on git master and nightly of 2018-02-28:

error[E0599]: no associated item named `Inherited` found for type `syntax::codemap::Spanned<syntax::ast::VisibilityKind>` in the current scope
   --> /home/svenstaro/.cargo/git/checkouts/stainless-0b08235192b57707/f89f435/src/generate.rs:135:18
    |
135 |             vis: ast::Visibility::Inherited,
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ associated item not found in `syntax::codemap::Spanned<syntax::ast::VisibilityKind>`

error[E0599]: no associated item named `Inherited` found for type `syntax::codemap::Spanned<syntax::ast::VisibilityKind>` in the current scope
   --> /home/svenstaro/.cargo/git/checkouts/stainless-0b08235192b57707/f89f435/src/generate.rs:179:18
    |
179 |             vis: ast::Visibility::Inherited,
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ associated item not found in `syntax::codemap::Spanned<syntax::ast::VisibilityKind>`

error[E0599]: no associated item named `Public` found for type `syntax::codemap::Spanned<syntax::ast::VisibilityKind>` in the current scope
   --> /home/svenstaro/.cargo/git/checkouts/stainless-0b08235192b57707/f89f435/src/generate.rs:228:47
    |
228 |         let super_glob = cx.item_use_glob(sp, ast::Visibility::Public, vec![cx.ident_of("super")]);
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^ associated item not found in `syntax::codemap::Spanned<syntax::ast::VisibilityKind>`
@svenstaro
Copy link
Contributor Author

ping @reem @ujh

@Deedasmi
Copy link

Are we to consider stainless broken and unmaintained?

@svenstaro
Copy link
Contributor Author

I mailed both maintainers directly months ago without an answer so yes, the project is broken and unmaintained.

@svenstaro
Copy link
Contributor Author

I think it's time for a proper fork. Are you up for maintaining that?

@utkarshkukreti
Copy link
Contributor

Since you're discussing about forking, I'd like to mention a package I wrote quite a while ago which is very similar to / inspired by stainless but has some additional features like declaring functions / consts / statics outside before/after and supports passing a string to describe blocks: https://github.com/utkarshkukreti/speculate.rs. It was just updated to support the latest nightly thanks to @gilescope (utkarshkukreti/speculate.rs#4).

It doesn't support the given and when aliases but I can add them if anyone needs it. Migrating to speculate should be straightforward:

  1. Replace before_each with before
  2. Replace after_each with after
  3. Change all inner describe blocks to pass a string and remove the !.
  4. Change the outermost describe! to speculate!.

I'm probably missing some things, so let me know if you run into any problems.

@reem
Copy link
Owner

reem commented May 16, 2018

Hey all, sorry for the communication delay, unfortunately I don't have time to maintain stainless any more. I would be amenable to adding more maintainers if others are interested in doing the work, so that people can continue to use the library if they find it helpful.

@svenstaro
Copy link
Contributor Author

@reem can you add me as a maintainer on here and on crates.io? My mail is svenstaro@gmail.com on both. I'm an Arch Linux developer and am a pretty active open source dude in case you need any credibility. You could also transfer the repo to my GitHub account so that I don't have to bug you in case I want to add some integrations to it.

@utkarshkukreti that looks pretty dope. I'll check that out.

@ms-ati
Copy link

ms-ati commented Jun 11, 2018

Is this transfer of maintainership of stainless happening @svenstaro @reem?

If not, in the interests of being good open source citizens, would you accept PRs to mark this as a dead project and direct to speculate instead, so that future folks have an easier time figuring out which BDD project is still alive?

@svenstaro
Copy link
Contributor Author

Honestly, at this point, I'm no longer interested in maintaining stainless. I switched over to speculate.rs and I'm happy with that.

@ms-ati
Copy link

ms-ati commented Jun 23, 2018

Oh for good grief @svenstaro @reem. Then could some one please, for the love and compassion for all folks new to Rust and its ecosystem, amend the README to mark stainless as dead and recommend that folks searching for the best project and community for rspec-inspired BDD in Rust check out speculate.rs instead?

Genuine question: is it acceptable to the Rust community for newcomers to have to ask for this?

By comparison, in my experience it's considered common courtesy in the Ruby ecosystem (among others) that when the most highly visible project in a given niche dies, they make BIG VISIBLE NOTICES referring newcomers to the most likely replacements.

Would you accept a pull request to do this?

@reem
Copy link
Owner

reem commented Jun 24, 2018 via email

@PSeitz
Copy link

PSeitz commented Jun 26, 2018

@reem You can fill me in as maintainer (pascal.seitz@gmail.com), I maintain a fork anyway https://github.com/PSeitz/stainless. You can also transfer the repo, this would make things easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants