Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deliver halted because lgtm not detected, but lgtm exists #119

Closed
sethladd opened this issue Jul 29, 2015 · 2 comments
Closed

deliver halted because lgtm not detected, but lgtm exists #119

sethladd opened this issue Jul 29, 2015 · 2 comments

Comments

@sethladd
Copy link
Contributor

screen shot 2015-07-29 at 3 25 45 pm

~/Code/dartdoc/test_package[sl-remove-overlay-on-resize] $ git reflow deliver
git fetch origin master
From github.com:dart-lang/dartdoc
 * branch            master     -> FETCH_HEAD

git checkout sl-remove-overlay-on-resize
Already on 'sl-remove-overlay-on-resize'
Your branch is up-to-date with 'origin/sl-remove-overlay-on-resize'.
git pull origin sl-remove-overlay-on-resize
From github.com:dart-lang/dartdoc
 * branch            sl-remove-overlay-on-resize -> FETCH_HEAD
Already up-to-date.
git checkout sl-remove-overlay-on-resize
Already on 'sl-remove-overlay-on-resize'
Your branch is up-to-date with 'origin/sl-remove-overlay-on-resize'.
[deliver halted] You still need a LGTM from: devoncarew

Notice how devoncarew gave an lgtm.

Any ideas why reflow won't deliver the feature?

@codenamev
Copy link
Collaborator

That is expected behavior. Since you added another commit after his approval, he would need to review those changes and give final approval no?

@sethladd
Copy link
Contributor Author

hm, good point. Not sure why I added another commit. Thanks for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants