fix: logger (#395)

refined-bitbucket · Dec 5, 2020 · 46caafa · 46caafa
1 parent facb6c1
commit 46caafa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -7,13 +7,13 @@
     "precommit": "lint-staged",
     "prettier": "prettier --write \"./**/*.{js,jsx,json,css,md,html}\"",
     "xo": "xo *.js {src,test,scripts}/**/*.js !src/vendor/*.*",
-    "ava": "cross-env BABEL_ENV=testing ava",
+    "ava": "cross-env NODE_ENV=test BABEL_ENV=testing ava",
     "ava:w": "npm run ava -- --watch",
     "flow": "flow check --color=always",
     "flow:w": "flow check --color=always & chokidar \"src/**/*.js\" -c \"flow check\"",
-    "build": "webpack",
+    "build": "cross-env NODE_ENV=production webpack",
     "test": "npm-run-all xo ava flow build",
-    "watch": "webpack --watch",
+    "watch": "cross-env NODE_ENV=development webpack --watch",
     "sync-version": "node scripts/sync-version",
     "package": "node scripts/package",
     "deploy": "npm-run-all test sync-version package && node scripts/deploy",

diff --git a/src/logger.js b/src/logger.js
@@ -1,9 +1,11 @@
 // @flow
 
+const isTestingEnvironment = process.env.NODE_ENV === 'test'
+
 const logger: typeof console = Object.keys(console).reduce(
     (previous, current) => {
         previous[current] = (...args: any[]) => {
-            if (!process) {
+            if (!isTestingEnvironment) {
                 console[current](...args)
             }
         }

diff --git a/webpack.config.js b/webpack.config.js
@@ -15,7 +15,7 @@ module.exports = {
     },
     plugins: [
         new webpack.DefinePlugin({
-            process: {},
+            'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
         }),
         new webpack.optimize.ModuleConcatenationPlugin(),
         new CopyWebpackPlugin([