Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Default Merge Startegy" or let users disable it #288

Closed
gronostajo opened this issue May 31, 2019 · 3 comments · Fixed by #289
Closed

Remove "Default Merge Startegy" or let users disable it #288

gronostajo opened this issue May 31, 2019 · 3 comments · Fixed by #289
Assignees

Comments

@gronostajo
Copy link

This feature was requested in #90 and introduced in #91. I think it's counter-productive, though. Bitbucket has its own, per-repository setting for this. Maybe it was introduced after #91? I don't know.

image

Refined Bitbucket overrides this setting for all repos. It leads to mistakes if you work with multiple repos that prefer different merge strategies. IMHO it would be better to let repository owners choose their preferred strategy. So I'd suggest to:

  • Remove this feature altogether in favor of the built-in one, or
  • Let users opt out of overriding this setting and respect the default
@reyronald
Copy link
Member

@gronostajo

This feature was originally requested to Atlassian by the community on Feb. 23, 2017 here. Bitbucket's product manager stated that it wasn't something they were prioritizing at the moment, despite the feature request having so many votes, so I added it as a feature to Refined Bitbucket on December 2017 (#91).

It only became available on Bitbucket around May 2018, but until then there was no confirmation if they were ever going to implement this themselves or not. So calling it counter-productive is a little bit disrespectful in my opinion, especially since I know that many people benefited from it.

So far no one had complained about the conflict you bring up on this issue, and that's why it hadn't being resolved.

I'll add the possibility of disabling it in the upcoming update.

Thanks

@reyronald reyronald self-assigned this Jun 4, 2019
reyronald added a commit that referenced this issue Jun 4, 2019
Add "None" option to the default merge
strategy feature as a way to disable it.

Closes #288
reyronald added a commit that referenced this issue Jun 4, 2019
Add "None" option to the default merge
strategy feature as a way to disable it.

Closes #288
reyronald added a commit that referenced this issue Jun 4, 2019
Add "None" option to the default merge
strategy feature as a way to disable it.

Closes #288
@reyronald
Copy link
Member

Released in v3.17.0

@gronostajo
Copy link
Author

Hi, thanks for the fix! I didn't mean to be disrespectful, I only meant that it's counter-productive right now, when this feature is available out of the box. I suspected that it may have been added there later, hence the "I don't know" part in original post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants