Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: add user-select none to filename badge #346

Merged
merged 1 commit into from
Apr 20, 2020
Merged

enh: add user-select none to filename badge #346

merged 1 commit into from
Apr 20, 2020

Conversation

jwallet
Copy link
Contributor

@jwallet jwallet commented Apr 14, 2020

Issue #344 : maybe the button is not needed anymore

added user-select:none on badge and icon to make sure they are ignored when selecting the filename

so when double-clicking on a filename we now can select the same string that this feature copy
(i changed the icon on my branch for the add line to clipboard from atlassian-icon)
image
frontend/src/helpers/authorization/abilityActions.js (copied)

/* fix ability to select filename correctly in a PR, removing Icon from being selected */
.filename span {
    user-select: none;
}

Copy link
Member

@reyronald reyronald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I really like the user-select: none idea! But I don't see that change in the PR, did you forget to push that commit?

About the icon, hmm, I think I prefer the original one, since it just requires one CSS class and no additional CSS file. Also the icon looks more recognizable to me, although I admit that's subjective 🤷‍♂️.

@jwallet
Copy link
Contributor Author

jwallet commented Apr 18, 2020

yeah forgot the commit
i removed the icon

Copy link
Member

@reyronald reyronald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@reyronald reyronald changed the title fix user-select to none to copy filename to clipboard enh: add user-select none to filename badge Apr 20, 2020
@reyronald reyronald merged commit 456730e into refined-bitbucket:dev Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants