-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autolinker #355
Fix autolinker #355
Conversation
@@ -0,0 +1,76 @@ | |||
;(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i minified my version of autolink in the file below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you modify this file yourself or is this an updated version of the autolinker plugin from Prism?
hey guys @reyronald @andremw let me know if you guys need more mainteners for this project, I think I might work on this extension for quite some times since I use it at work and Bitbucket Cloud is kind of a mess. I will like to set up continuous integration tool, automated tests for prs using appveyor so we don't merge failed unit tests by mistake, it's quick and reliable, or setting up a board to leave notes or let you know what I'm working on, for instance currently i'm on custom/default reviewers |
CI is already set-up with Travis, you can check it out here: https://travis-ci.org/github/refined-bitbucket/refined-bitbucket It was running automatically with PRs and commits before but apparently it was de-activated somehow, I'll re-activate it again, thanks for pointing that out Setting up a board seems overkill to be honest, I don't think we need that. |
Hey, @jwallet, it's been a long time since I stopped using BitBucket (and the extension) but @reyronald has done a brilliant work so far, so he's the one who will be able to bring you aboard as an official maintainer. |
don't decode url just link it
don't parse partial url as url (actual fix)
added support for data scheme (data:image, data:text, ?base64)
I updated the CHANGELOG.md
I tested the changes in this pull request myself
I added Automated Tests
I added an Option to enable / disable this feature
I updated the README.md, with pictures if necessary
https://bitbucket.org/walletj/test/commits/64480cc901aef941c3095f580665e23ca2f467cb?w=1
the filename actually does not matter for autolinker, that's why i created a .js file and pasted every previous error rbb users got
in the screenshot, links are in blue and other lines are reported strings in the issues below that parsed/converted by autolink and they render fine now
replace
// #355
by// #335
in the screenshotCloses #234
Closes #254
Closes #264
Closes #303
Closes #331
Closes #335