Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse diff scrolling effect only on bottom toggle #357

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Collapse diff scrolling effect only on bottom toggle #357

merged 2 commits into from
Jul 29, 2020

Conversation

jwallet
Copy link
Contributor

@jwallet jwallet commented May 17, 2020

if the header never reached the top of the screen we should normally don't add the scrolling effect when collapsing.

  • maybe we can also add an option with scrolling behavior

gh

close #356

  • I updated the CHANGELOG.md
  • I tested the changes in this pull request myself
  • I added Automated Tests
  • I added an Option to enable / disable this feature
  • I updated the README.md, with pictures if necessary

if the header never reached the top of the screen we should normally don't add the scrolling effect when collapsing.
@andremw andremw requested a review from reyronald July 20, 2020 18:19
Copy link
Member

@reyronald reyronald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!

@reyronald reyronald merged commit dbfaecb into refined-bitbucket:dev Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse diff scrolling effect makes it difficult to review pr on vertical screen
2 participants