Trim all duplicate slashes #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
changed the title
yakov116
reviewed
Nov 16, 2021
3 tasks
kidonng
commented
Nov 16, 2021
fregante
reviewed
Nov 18, 2021
Co-authored-by: Federico Brigante <me@fregante.com>
kidonng
changed the title
|
By the way the issue was that the tests are running on a node version that doesn’t have replaceAll. But the current solution is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though very rare, it is possible to have multiple
leading and trailingsuccessive slashes in
pathname.