Add hasFooEditor

[kidonng]

Reason: both kind of pages are almost identical ("editing something").

While both are frequently used together, sometimes isNewFoo is easily left out since it's a special case that doesn't matter most of the time.

To replicate the old behavior of isEditingFoo, use isEditingFoo() && !isNewFoo().

We need some utils to check for these pages at the same time.

Changes:

• Add hasFileEditor: isEditingFile, isNewFile and isDeletingFile
• Add hasReleaseEditor: isEditingRelease and isNewRelease
• Add hasWikiPageEditor: isEditingWikiPage and isNewWikiPage
• hasRichTextEditor checks for hasReleaseEditor instead of isEditingRelease

[kidonng]

@fregante Just curious, is there anything preventing this repo from migrating to @refined-github? Or do you simply prefer to keep it as-is?

[fregante]

Good idea, I think it'd be better to add isFooEditor and leave those alone.

I chose not to migrate it for now

[kidonng]

Good idea, I think it'd be better to add isFooEditor and leave those alone.

Sounds good, breaking changes matter. I do consider the name a little bit weird though.

Regardless of how this is going, hasRichTextEditor needs to be updated and I'm going to make a PR in RGH to go through every instances of these includes.

[fregante]

Sounds good, breaking changes matter. I do consider the name a little bit weird though.

"Weird" in the sense that there's no "file editor" page. Is "hasFileEditor" better?

[fregante]

You can also mark them as combinedTestOnly to avoid having to list the URLs. But it's fine either way

[fregante]

You can merge this PR, I added you as a collab. You can release a new minor version: https://github.com/fregante/github-url-detection/actions/workflows/npm-publish.yml

patch is for fixes
minor is for new detections
major is rare, breaking changes

[fregante]

@fregante Just curious, is there anything preventing this repo from migrating to @refined-github? Or do you simply prefer to keep it as-is?

I will try to move this repo to the organization, but I have to set up redirects for the github.io domain, change the meta, and then ensure that the secrets still work.

You can help by opening a PR to make the meta changes (fregante/github-url-detection -> refined-github/github-url-detection)

Ideally we'd also have the same npm auto-publishing setup on the other repository, so PR welcome there too to copy the workflow.