Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isPrivateUserProfile #125

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Add isPrivateUserProfile #125

merged 1 commit into from
Jul 11, 2022

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jul 11, 2022

To be used in Refined GitHub.

There are several ways to tell if a user profile is private, here we are looking at whether the (un)follow button exist or not.

@fregante
Copy link
Member

To be used in Refined GitHub

Can you include the reason when you open a PR? Ideally we’d always merge into RG first and then extract later.

@fregante
Copy link
Member

Just saw refined-github/refined-github#5814

It’s always best to add a link between related PRs

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be released

@kidonng
Copy link
Member Author

kidonng commented Jul 11, 2022

It’s always best to add a link between related PRs

It's because this PR is submitted first, then I went to work on the other PR and forgot to add the link back.

@kidonng kidonng merged commit f7cf628 into main Jul 11, 2022
@kidonng kidonng deleted the isPrivateUserProfile branch July 11, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants