Ensure is[Status]PR only matches PRs and not issues
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preview-for-github-url-detection ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Jul 24, 2022
Closed
|
I think we should still have isClosedConversation that includes both pr and issue with a limitation to the conversation tab. |
|
That sounds way too specific:
In its only instance in RGH, it can be replaced by: asLongAs: [
isConversation,
],
include: [
isClosedIssue, // added in this PR
isClosedPR,
],we can revisit if we end up having a lot of features on "closed conversations", but probably not anytime soon. |
fregante
changed the title
is[Status]PR only matches PRsis[Status]PR only matches PRs and not issues
|
Not sure if this is what inspired this PR, but it seems issues may (already?) have a "Draft" status as well: github/roadmap#289 (This page stayed in my bookmark for a month because I forgot to post it😅) |
|
It affected open/close states too because the select was just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts this PR and instead ensures that
isClosedPR,isOpenPR, etc only match PRs:isClosedConversation#120