Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isPRFile404 #20

Merged
merged 8 commits into from
Jul 7, 2020
Merged

Add isPRFile404 #20

merged 8 commits into from
Jul 7, 2020

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Jul 5, 2020

Does not follow refined-github/refined-github#3314 (comment) 馃槃

isPRCommit404 exists. I need the file 404

@fregante fregante added the enhancement New feature or request label Jul 5, 2020
@yakov116
Copy link
Member Author

yakov116 commented Jul 5, 2020

test is timing out...

@fregante
Copy link
Member

fregante commented Jul 6, 2020

I don't know what's wrong with the tests, they're throwing here too: #21

@fregante
Copy link
Member

fregante commented Jul 7, 2020 •
edited

Try writing the tests again, copy the isPRCommit404 test and make small changes until it works/break. That's how I fixed #21

@yakov116
Copy link
Member Author

yakov116 commented Jul 7, 2020

Weird...
Ok will try

@yakov116
Copy link
Member Author

yakov116 commented Jul 7, 2020

@fregante passed...

@fregante fregante merged commit 63005a4 into refined-github:master Jul 7, 2020
@yakov116 yakov116 deleted the isPrFile404 branch July 7, 2020 21:00
@yakov116
Copy link
Member Author

yakov116 commented Jul 7, 2020

馃殌 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yakov116 @fregante