Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify and fix isRepoRoot #25

Merged
merged 12 commits into from
Jul 24, 2020
Merged

Clarify and fix isRepoRoot #25

merged 12 commits into from
Jul 24, 2020

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 22, 2020 •
edited

@fregante fregante added the bug Something isn't working label Jul 22, 2020
@yakov116 yakov116 mentioned this pull request Jul 23, 2020
Closed
fregante
fregante commented Jul 23, 2020
View reviewed changes
index.ts Outdated Show resolved Hide resolved
@yakov116
Copy link
Member

@fregante how can I test it? is there a way to link a this pull in the RH package.json? I get an error when trying.

@kidonng
Copy link
Member

kidonng commented Jul 24, 2020

@yakov116 Try npm i fregante/github-url-detection@is-repo-root

@fregante
Copy link
Member Author

fregante commented Jul 24, 2020 •
edited

No, you have to download it locally and build it; then you can npm install or npm link that folder

@kidonng
Copy link
Member

kidonng commented Jul 24, 2020

😅 I forgot this is a TS project

yakov116
yakov116 approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@yakov116 yakov116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great!

@fregante fregante merged commit 97e4f39 into master Jul 24, 2020
@fregante fregante deleted the is-repo-root branch July 24, 2020 17:49
fregante
fregante commented Jul 24, 2020
View reviewed changes
Copy link
Member Author

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakov116 yakov116 yakov116 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
3 participants
@fregante @yakov116 @kidonng