Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative URLs in getRepoURL #29

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Fix relative URLs in getRepoURL #29

merged 1 commit into from
Jul 26, 2020

Conversation

fregante
Copy link
Member

This should fix #28

@fregante fregante added the bug Something isn't working label Jul 26, 2020
@fregante
Copy link
Member Author

cc @yakov116

@yakov116
Copy link
Member

Works!

@fregante fregante merged commit dd4dbfb into master Jul 26, 2020
@fregante fregante deleted the relative-urls-repourl branch July 26, 2020 14:24
@fregante
Copy link
Member Author

This means I have to release a hotfix for RG, doesn't it?

@yakov116
Copy link
Member

Yes

@fregante
Copy link
Member Author

Did it only break releases-tab and recently-pushed-branches-enhancements on Releases? Doesn't feel too urgent so far. Let's see if we broke anything else first (or wait until Thursday)

@yakov116
Copy link
Member

As soon as I saw it broke on releases I did a mass check. I dont see any where else.

@fregante
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[property="og:url"] does not give the full url on the release page
2 participants
@fregante @yakov116