Replace getRepoURL and getRepoPath with getRepositoryInfo

[fregante]

Initially added in Refined GitHub, I think we can bring this over, unify it and deprecate any other function.

The 2 functions aren't mapped exactly to getRepositoryInfo. Here are the differences:

• getRepoURL did not actually check isRepo, so it would return 'settings' if you were on https://github.com/settings
• getRepoPath did not use the canonical URL, however this probably isn't much of an issue generally

I need to ensure that this doesn't impact the current usage in RGH

[fregante]

cc @yakov116 for any comments

I'll replace the usage of the deprecated functions both here and in RG before merging

[fregante]

I decided to return {} instead of undefined to make it easier to check without having to use ?.

// Before:
if (getRepoPath() === undefined) 

// Now:
if (getRepositoryInfo().path === undefined)

// If it returned `undefined`:
if (getRepositoryInfo()?.path === undefined)

[fregante]

Changed my mind. Returning Partial<RepositoryInfo> is actually wrong because the type is actually RepositoryInfo | {}.

The difference is that with the first one, even if you typecheck if !repository.name, return, .path will still be string | undefined, even if we know for sure it's a string.

Unfortunately RepositoryInfo | {} is awkward to use because repository.name will cause a type error: name doesn't exist on {}.

In short, since we have ?. in the language, let's make use of it for ease of use, even if it generates slightly longer code.

[yakov116]

I debated this when I did the lint. One thing that held me back was that we sometimes need the repo url in lower case. So I backed off changing it all and just kept getRepoURL since I was not sure what needed it.

[fregante]

Good point. I added a couple of notes to my first post as well.

[fregante]

Pre-published as 4.3.0-0

[fregante]

we sometimes need the repo url in lower case

Do we? I think this was solved by our use of og:url in most cases. I'll try to replace our getRepoURL usage everywhere and we can review them in refined-github/refined-github#3695

The only annoyance is that getRepoURL() becomes getRepositoryInfo()!.url and that it's a little slower because it runs more checks.

[yakov116]

Do we?

https://github.com/sindresorhus/refined-github/blob/5b6b9c033e26da85ce9dc164801411da4d50b446/source/features/forked-to.tsx#L81

If I am not mistaken it was added because of that line. Will look for the PR to confirm.

[fregante]

Yeah, I mean we just need to make sure that all the comparisons are made on the same normalized content. In some cases we could still use getRepositoryInfo()!.url.toLowerCase() (😬), but not all.

[fregante]

Last 2 points:

• rename url to nameWithOwner to match GitHub’s wording and that it's not an actual url
• in most cases, this is "slower" than it needs to be since it introduces the normalization and isRepo… but I probably shouldn't worry about this