Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isDiscussionList and isDiscussion #59

Merged
merged 4 commits into from
Feb 14, 2021
Merged

Add isDiscussionList and isDiscussion #59

merged 4 commits into from
Feb 14, 2021

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Feb 14, 2021 •
edited

Tested

@fregante
Copy link
Member

fregante commented Feb 14, 2021 •
edited

How similar is the DOM? Because hasComments lets you assume we have certain classes and elements, and loading mechanism. It’s worth taking a look at what features use that detection and if they cause errors on Discussions if hasComments includes that.

@yakov116
Copy link
Member Author

How similar is the DOM? Because hasComments lets you assume we have certain classes and elements, and loading mechanism. It’s worth taking a look at what features use that detection and if they cause errors on Discussions if hasComments includes that.

Untested

Testing now

@yakov116 yakov116 marked this pull request as ready for review February 14, 2021 21:51
@fregante
Copy link
Member

Not compatible?

@fregante fregante added the enhancement New feature or request label Feb 14, 2021
@fregante fregante changed the title Add isDiscussionList and isDiscussion Add isDiscussionList and isDiscussion Feb 14, 2021
@fregante
Copy link
Member

You can merge and publish as minor when it's ready

Screen Shot

@yakov116
Copy link
Member Author

Not compatible?

Not at all!, I got about 12 errors LOL

@yakov116 yakov116 merged commit c872099 into master Feb 14, 2021
@yakov116 yakov116 deleted the yakov116-discussions branch February 14, 2021 22:18
@fregante
Copy link
Member

Thanks for the PR and especially for the sponsorship, you shouldn't have! 😁

@yakov116
Copy link
Member Author

Na, you deserve it. I have gained from your work immensely!

@yakov116 yakov116 mentioned this pull request May 11, 2021
Closed
@fregante fregante mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yakov116 @fregante