Skip to content

Commit

Permalink
Improve clickability of batch-mark-files-as-viewed (#4156)
Browse files Browse the repository at this point in the history
  • Loading branch information
yakov116 committed Mar 30, 2021
1 parent 00ddcbb commit 5e0bf08
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions source/features/batch-mark-files-as-viewed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function batchToggle(event: delegate.Event<MouseEvent, HTMLFormElement>): void {
}

function markAsViewedSelector(target: HTMLElement): string {
const checked = (target as HTMLInputElement).checked ? ':not([checked])' : '[checked]';
const checked = isChecked(target) ? '[checked]' : ':not([checked])';
return '.js-reviewed-checkbox' + checked;
}

Expand All @@ -55,18 +55,18 @@ function onAltClick(event: delegate.Event<MouseEvent, HTMLInputElement>): void {
void showToast(async () => {
markAsViewed(event);
}, {
message: event.delegateTarget.checked ?
'Marking visible files as viewed' :
'Marking visible files as unviewed',
message: isChecked(event.delegateTarget) ?
'Marking visible files as unviewed' :
'Marking visible files as viewed',
doneMessage: 'Marking files completed'
});
}

function init(): void {
// `mousedown` required to avoid mouse selection on shift-click
delegate(document, '.js-toggle-user-reviewed-file-form', 'mousedown', batchToggle);
delegate(document, '.js-toggle-user-reviewed-file-form', 'submit', remember);
delegate(document, '.js-reviewed-checkbox', 'click', onAltClick);
delegate(document, '.js-reviewed-toggle', 'mousedown', batchToggle);
delegate(document, '.js-reviewed-toggle', 'submit', remember);
delegate(document, '.js-reviewed-toggle', 'click', onAltClick);
}

function deinit(): void {
Expand Down

0 comments on commit 5e0bf08

Please sign in to comment.