Fix z-index bug in quick-repo-deletion and sticky-sidebar (#4364)

refined-github · May 16, 2021 · 653cd95 · 653cd95
1 parent 73fa11a
commit 653cd95
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/source/features/quick-repo-deletion.css b/source/features/quick-repo-deletion.css
@@ -1,10 +1,11 @@
 :root .rgh-quick-repo-deletion[open] span {
 	position: relative;
-	z-index: 81;
+	z-index: 91; /* Higher than sticky readme header and `sticky-sidebar` #4192 */
 	transform-origin: top;
 }
 
 :root .rgh-quick-repo-deletion[open] summary::before {
 	background-color: var(--color-scale-red-6);
 	opacity: 30%;
+	z-index: 91; /* Higher than sticky readme header and `sticky-sidebar` #4192 */
 }
diff --git a/source/features/sticky-sidebar.css b/source/features/sticky-sidebar.css
@@ -5,12 +5,18 @@
 .rgh-sticky-sidebar {
 	position: sticky;
 	top: 0;
-	z-index: 1; /* `sticky` will trap the `fixed` dialog’s z-index in some sidebars #3732 */
+
+	/* `sticky` will trap the `fixed` dialog’s z-index in some sidebars #3732 */
+	/* Higher than sticky readme header #4192 */
+	z-index: 90;
 }
 
 #partial-discussion-sidebar.rgh-sticky-sidebar {
 	top: 76px !important; /* Sticky header's height + sidebar item's margin */
-	z-index: 1; /* Needed so the backdrop of notification modal is over the other elements in the conversation */
+
+	/* Needed so the backdrop of notification modal is over the other elements in the conversation */
+	/* Higher than sticky readme header #4192 */
+	z-index: 90;
 }
 
 /* Hides the last divider (on pull requests) to avoid https://user-images.githubusercontent.com/10238474/62282128-af6fb980-b457-11e9-8b18-c29687b88da1.gif */