Fix text formatting error with non-Roman inputs (#2204)

refined-github · Jul 3, 2019 · 6d852ce · 6d852ce
1 parent cb19423
commit 6d852ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/source/features/comment-fields-keyboard-shortcuts.tsx b/source/features/comment-fields-keyboard-shortcuts.tsx
@@ -79,7 +79,7 @@ function init(): void {
 					select<HTMLTextAreaElement>('.js-comment-field', lastOwnComment)!.selectionStart = Number.MAX_SAFE_INTEGER;
 				});
 			}
-		} else if (formattingCharacters.includes(event.key)) {
+		} else if (formattingCharacters.includes(event.key) && !event.isComposing) {
 			const [start, end] = [field.selectionStart, field.selectionEnd];
 
 			// If `start` and `end` of selection are the same, then no text is selected

diff --git a/source/globals.d.ts b/source/globals.d.ts
@@ -87,3 +87,8 @@ declare namespace JSX {
 interface NamedNodeMap {
 	[key: string]: Attr;
 }
+
+// TODO: Drop when this appears on npm https://github.com/microsoft/TypeScript/blob/340f81035ff1d753e6a1f0fedc2323d169c86cc6/src/lib/dom.generated.d.ts#L9686
+interface KeyboardEvent {
+	readonly isComposing: boolean;
+}