Automatically set popup to contain options on iOS (#6592)

- Includes
https://github.com/fregante/webext-detect-page/releases/tag/v4.1.0
- Will fix #6587

package.json

@@ -78,10 +78,10 @@
 		"ts-extras": "^0.11.0",
 		"twas": "^2.1.3",
 		"webext-base-css": "^1.4.3",
-		"webext-detect-page": "^4.0.1",
-		"webext-domain-permission-toggle": "^4.0.0-0",
+		"webext-detect-page": "^4.1.0",
+		"webext-domain-permission-toggle": "^4.0.1",
 		"webext-dynamic-content-scripts": "^9.2.0",
-		"webext-options-sync-per-domain": "^4.0.0-0",
+		"webext-options-sync-per-domain": "^4.0.0",
 		"webext-storage-cache": "^6.0.0-2",
 		"webextension-polyfill": "^0.10.0",
 		"zip-text-nodes": "^1.0.0"

source/background.ts

@@ -4,13 +4,18 @@ import {isSafari} from 'webext-detect-page';
 import {objectKeys} from 'ts-extras';
 import addDomainPermissionToggle from 'webext-domain-permission-toggle';
 
-import optionsStorage from './options-storage';
+import optionsStorage, {isBrowserActionAPopup} from './options-storage';
 import {getRghIssueUrl} from './helpers/rgh-issue-link';
 import isDevelopmentVersion from './helpers/is-development-version';
 
 // GHE support
 addDomainPermissionToggle();
 
+// No "Button link" support in iOS Safari
+if (isBrowserActionAPopup) {
+	void browser.browserAction.setPopup({popup: 'options.html'});
+}
+
 const messageHandlers = {
 	openUrls(urls: string[], {tab}: browser.runtime.MessageSender) {
 		for (const [i, url] of urls.entries()) {

source/options-storage.ts

@@ -1,9 +1,12 @@
+import {isMobileSafari} from 'webext-detect-page';
 import OptionsSyncPerDomain from 'webext-options-sync-per-domain';
 
 import {importedFeatures} from '../readme.md';
 
 export type RGHOptions = typeof defaults;
 
+export const isBrowserActionAPopup = isMobileSafari();
+
 // eslint-disable-next-line prefer-object-spread -- TypeScript doesn't merge the definitions so `...` is not equivalent.
 const defaults = Object.assign({
 	actionUrl: '',

source/options.tsx

@@ -15,7 +15,7 @@ import clearCacheHandler from './helpers/clear-cache-handler';
 import {getLocalHotfixes} from './helpers/hotfix';
 import {createRghIssueLink} from './helpers/rgh-issue-link';
 import {importedFeatures, featuresMeta} from '../readme.md';
-import {perDomainOptions} from './options-storage';
+import {isBrowserActionAPopup, perDomainOptions} from './options-storage';
 
 type Status = {
 	error?: true;
@@ -289,6 +289,11 @@ function addEventListeners(): void {
 			window.open(event.delegateTarget.href);
 		}
 	});
+
+	// Hide non-applicable "Button link" section
+	if (isBrowserActionAPopup) {
+		select('#action')!.hidden = true;
+	}
 }
 
 async function init(): Promise<void> {